Skip to content

Commit 387fff5

Browse files
committed
Ignore cbindgen version in latest-bindings-in-git check.
Currently the check_binidngs GitHub CI job always fails when there is a new cbindgen release because the cbindgen version is in the generated header file. When the new version doesn't change the generated header except for the version number, we should ignore the difference.
1 parent 73c46cc commit 387fff5

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/build.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -168,8 +168,8 @@ jobs:
168168
# cbindgen's bindings output order can be FS-dependant, so check that the lines are all the same:
169169
mv lightning-c-bindings/include/lightning.h lightning-c-bindings/include/lightning.h.new
170170
git checkout lightning-c-bindings/include/lightning.h
171-
cat lightning-c-bindings/include/lightning.h | sort > lightning-c-bindings/include/lightning.h.sorted
172-
cat lightning-c-bindings/include/lightning.h.new | sort > lightning-c-bindings/include/lightning.h.new.sorted
171+
cat lightning-c-bindings/include/lightning.h | grep -v "Generated with cbindgen:[0-9\.]*" | sort > lightning-c-bindings/include/lightning.h.sorted
172+
cat lightning-c-bindings/include/lightning.h.new | grep -v "Generated with cbindgen:[0-9\.]*" | sort > lightning-c-bindings/include/lightning.h.new.sorted
173173
diff lightning-c-bindings/include/lightning.h.sorted lightning-c-bindings/include/lightning.h.new.sorted
174174
#
175175
mv lightning-c-bindings/include/lightningpp.hpp lightning-c-bindings/include/lightningpp.hpp.new

0 commit comments

Comments
 (0)