Skip to content

Commit 3a0ce05

Browse files
committed
f update release notes
1 parent d727263 commit 3a0ce05

File tree

1 file changed

+20
-15
lines changed

1 file changed

+20
-15
lines changed

CHANGELOG.md

Lines changed: 20 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,6 @@
1717
`ChannelMonitor`s (#2359).
1818
* Batch funding of outbound channels is now supported using the new
1919
`ChannelManager::batch_funding_transaction_generated` method (#2486).
20-
* `ChannelDetails::balance_msat` has been removed. Inclusion criteria for that
21-
balance was generally unexpected and led to surprising values. Instead, use
22-
sum of `ChainMonitor::get_claimable_balances(..).claimable_amount_satoshis()`
23-
and HTLC balances (#2476).
2420
* `ChannelManager::send_preflight_probes` has been added to probe a payment's
2521
potential paths while a user is providing approval for a payment (#2534).
2622
* Fully asynchronous `ChannelMonitor` updating is available as an alpha
@@ -40,7 +36,7 @@
4036
* `LockableScore` now supports read locking for parallel routefinding (#2197).
4137
* `ChannelMonitor::get_spendable_outputs` was added to allow for re-generation
4238
of `SpendableOutputDescriptor`s for a channel after they were provided via
43-
`Event::SpendableOutputs` (#2609).
39+
`Event::SpendableOutputs` (#2609, #2624).
4440
* `[u8; 32]` has been replaced with a `ChannelId` newtype for chan ids (#2485).
4541
* `NetAddress` was renamed `SocketAddress` (#2549) and `FromStr` impl'd (#2134)
4642
* HTLC information is now provided in `Event::PaymentClaimed::htlcs` (#2478).
@@ -79,11 +75,14 @@
7975
* Then ensure all `ChannelMonitorUpdate`s stored are fully applied to the
8076
relevant `ChannelMonitor`,
8177
* finally, write each full `ChannelMonitor` using your new `Persist` impl.
82-
* `ChannelDetails` serialized with versions of LDK >= 0.0.117 will have their
83-
`balance_msat` field set to `next_outbound_htlc_limit_msat` when read by
84-
versions of LDK prior to 0.0.117 (#2476).
8578

8679
## Bug Fixes
80+
* Anchor channels which were closed by a counterparty broadcasting its
81+
commitment transaction (i.e. force-closing) would previously not generate a
82+
`SpendableOutputs` event for the `to_local` (i.e. non-HTLC-encumbered)
83+
balance. Those with such balances available should fetch the missing
84+
`SpendableOutputDescriptor`s using the new
85+
`ChannelMonitor::get_spendable_outputs` method (#2605).
8786
* Anchor channels HTLC claims on-chain previously spent the entire value of any
8887
HTLCs as fee, which has now been fixed (#2587).
8988
* `ChannelManager::send_spontaneous_payment_with_retry` spuriously did not
@@ -121,19 +120,25 @@
121120

122121
## Security
123122
0.0.117 fixes several loss-of-funds vulnerabilities in anchor output channels,
124-
support for which was added in 0.0.116. In addition, it fixes a potential
125-
loss-of-funds issue when accepting channel(s) from counterparties which are
126-
miners and using the coinbase transaction's outputs to fund the channel.
123+
support for which was added in 0.0.116, in reorg handling, and when accepting
124+
channel(s) from counterparties which are miners.
127125
* When a counterparty broadcasts their latest commitment transaction for a
128-
channel, we'd previously fail to build claiming transactions against any
129-
HTLC outputs in that transaction. This could lead to loss of funds if the
130-
counterparty is able to eventually claim the HTLC after a timeout (#2606).
126+
channel with anchor outputs, we'd previously fail to build claiming
127+
transactions against any HTLC outputs in that transaction. This could lead
128+
to loss of funds if the counterparty is able to eventually claim the HTLC
129+
after a timeout (#2606).
130+
* If a channel is closed via an on-chain commitment transaction confirmation
131+
with a pending outbound HTLC in the commitment transaction, followed by a
132+
reorg which replaces the confirmed commitment transaction with a different
133+
(but non-revoked) commitment transaction, all before we learn the payment
134+
preimage for this HTLC, we may previously have not generated a proper
135+
claiming transaction for the HTLC's value (#2623).
131136
* 0.0.117 now correctly handles channels for which our counterparty funded the
132137
channel with a coinbase transaction. As such transactions are not spendable
133138
until they've reached 100 confirmations, this could have resulted in
134139
accepting HTLC(s) which are not enforcible on-chain (#1924).
135140

136-
up to date as of 6016101ac8ff31275f31f68eef8d33e94b19c0b1
141+
up to date as of 620244dc2ec3153a61e009b80a8c59cf41514482
137142
XXX: add diff statas
138143

139144
# 0.0.116 - Jul 21, 2023 - "Anchoring the Roadmap"

0 commit comments

Comments
 (0)