f split consistency lock + swallow panic output

Author: valentinewallace

background-processor/src/lib.rs

@@ -314,17 +314,19 @@ mod tests {
 			Err(std::io::Error::new(std::io::ErrorKind::Other, "test"))
 		}
 
+		std::panic::set_hook(Box::new(|panic_info| {
+			if let Some(s) = panic_info.payload().downcast_ref::<String>() {
+				assert_eq!(s, "Errored persisting manager: test");
+			} else {
+				panic!("Expected string panic");
+			}
+		}));
+
 		let nodes = create_nodes(2, "test_persist_error".to_string());
 		let bg_processor = BackgroundProcessor::start(persist_manager, nodes[0].node.clone(), nodes[0].logger.clone());
 		open_channel!(nodes[0], nodes[1], 100000);
 
-		match bg_processor.thread_handle.join() {
-			Err(e) => {
-				let error = e.downcast_ref::<String>().unwrap();
-				assert_eq!("Errored persisting manager: test", error);
-			}
-			_ => panic!("Unexpected result")
-		}
+		let _ = bg_processor.thread_handle.join().expect_err("Errored persisting manager: test");
 	}
 
 	#[test]