Skip to content

Commit 3f9a7de

Browse files
committed
Util-ify enqueueing an encoded message in peer_handler
This marginally simplifies coming commits.
1 parent e496c9b commit 3f9a7de

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

lightning/src/ln/peer_handler.rs

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -722,14 +722,17 @@ impl<Descriptor: SocketDescriptor, CM: Deref, RM: Deref, L: Deref, CMH: Deref> P
722722
}
723723
}
724724

725-
/// Append a message to a peer's pending outbound/write buffer, and update the map of peers needing sends accordingly.
725+
/// Append a message to a peer's pending outbound/write buffer
726+
fn enqueue_encoded_message(&self, peer: &mut Peer, encoded_message: &Vec<u8>) {
727+
peer.pending_outbound_buffer.push_back(peer.channel_encryptor.encrypt_message(&encoded_message[..]));
728+
}
729+
730+
/// Append a message to a peer's pending outbound/write buffer
726731
fn enqueue_message<M: wire::Type>(&self, peer: &mut Peer, message: &M) {
727732
let mut buffer = VecWriter(Vec::with_capacity(2048));
728733
wire::write(message, &mut buffer).unwrap(); // crash if the write failed
729-
let encoded_message = buffer.0;
730-
731734
log_trace!(self.logger, "Enqueueing message {:?} to {}", message, log_pubkey!(peer.their_node_id.unwrap()));
732-
peer.pending_outbound_buffer.push_back(peer.channel_encryptor.encrypt_message(&encoded_message[..]));
735+
self.enqueue_encoded_message(peer, &buffer.0);
733736
}
734737

735738
fn do_read_event(&self, peer_descriptor: &mut Descriptor, data: &[u8]) -> Result<bool, PeerHandleError> {
@@ -1118,7 +1121,7 @@ impl<Descriptor: SocketDescriptor, CM: Deref, RM: Deref, L: Deref, CMH: Deref> P
11181121
if except_node.is_some() && peer.their_node_id.as_ref() == except_node {
11191122
continue;
11201123
}
1121-
peer.pending_outbound_buffer.push_back(peer.channel_encryptor.encrypt_message(&encoded_msg[..]));
1124+
self.enqueue_encoded_message(peer, &encoded_msg);
11221125
}
11231126
},
11241127
wire::Message::NodeAnnouncement(ref msg) => {
@@ -1140,7 +1143,7 @@ impl<Descriptor: SocketDescriptor, CM: Deref, RM: Deref, L: Deref, CMH: Deref> P
11401143
if except_node.is_some() && peer.their_node_id.as_ref() == except_node {
11411144
continue;
11421145
}
1143-
peer.pending_outbound_buffer.push_back(peer.channel_encryptor.encrypt_message(&encoded_msg[..]));
1146+
self.enqueue_encoded_message(peer, &encoded_msg);
11441147
}
11451148
},
11461149
wire::Message::ChannelUpdate(ref msg) => {
@@ -1159,7 +1162,7 @@ impl<Descriptor: SocketDescriptor, CM: Deref, RM: Deref, L: Deref, CMH: Deref> P
11591162
if except_node.is_some() && peer.their_node_id.as_ref() == except_node {
11601163
continue;
11611164
}
1162-
peer.pending_outbound_buffer.push_back(peer.channel_encryptor.encrypt_message(&encoded_msg[..]));
1165+
self.enqueue_encoded_message(peer, &encoded_msg);
11631166
}
11641167
},
11651168
_ => debug_assert!(false, "We shouldn't attempt to forward anything but gossip messages"),

0 commit comments

Comments
 (0)