Make IntroductionNode type private.

Since we made the BlindedPath type private in favor of
Blinded{Message,Payment}Path types, this type isn't used in the public api
anymore.

Author: valentinewallace

lightning/src/blinded_path/message.rs

@@ -82,8 +82,8 @@ impl BlindedMessagePath {
 		}))
 	}
 
-	/// Attempts to a use a compact representation for the [`IntroductionNode`] by using a directed
-	/// short channel id from a channel in `network_graph` leading to the introduction node.
+	/// Attempts to a use a compact representation for the introduction node by using a directed short
+	/// channel id from a channel in `network_graph` leading to the introduction node.
 	///
 	/// While this may result in a smaller encoding, there is a trade off in that the path may
 	/// become invalid if the channel is closed or hasn't been propagated via gossip. Therefore,

lightning/src/blinded_path/mod.rs

@@ -55,15 +55,15 @@ pub(super) struct BlindedPath {
 
 /// The unblinded node in a blinded path.
 #[derive(Clone, Debug, Hash, PartialEq, Eq)]
-pub enum IntroductionNode {
+pub(crate) enum IntroductionNode {
 	/// The node id of the introduction node.
 	NodeId(PublicKey),
 	/// The short channel id of the channel leading to the introduction node. The [`Direction`]
 	/// identifies which side of the channel is the introduction node.
 	DirectedShortChannelId(Direction, u64),
 }
 
-/// The side of a channel that is the [`IntroductionNode`] in a blinded path. [BOLT 7] defines which
+/// The side of a channel that is the introduction node in a blinded path. [BOLT 7] defines which
 /// nodes is which in the [`ChannelAnnouncement`] message.
 ///
 /// [BOLT 7]: https://github.com/lightning/bolts/blob/master/07-routing-gossip.md#the-channel_announcement-message

lightning/src/onion_message/messenger.rs

@@ -692,9 +692,9 @@ pub enum Destination {
 }
 
 impl Destination {
-	/// Attempts to resolve the [`IntroductionNode::DirectedShortChannelId`] of a
-	/// [`Destination::BlindedPath`] to a [`IntroductionNode::NodeId`], if applicable, using the
-	/// provided [`ReadOnlyNetworkGraph`].
+	/// Attempts to resolve the short channel id corresponding to the introduction node of a
+	/// [`Destination::BlindedPath`] to a node id, if applicable, using the provided
+	/// [`ReadOnlyNetworkGraph`].
 	pub fn resolve(&mut self, network_graph: &ReadOnlyNetworkGraph) {
 		if let Destination::BlindedPath(path) = self {
 			if let IntroductionNode::DirectedShortChannelId(..) = path.introduction_node() {
@@ -862,7 +862,8 @@ where
 /// needed to connect to the first node.
 ///
 /// Returns [`SendError::UnresolvedIntroductionNode`] if:
-/// - `destination` contains a blinded path with an [`IntroductionNode::DirectedShortChannelId`],
+/// - `destination` contains a blinded path where the introduction node is represented by a short
+///   channel id,
 /// - unless it can be resolved by [`NodeIdLookUp::next_node_id`].
 /// Use [`create_onion_message_resolving_destination`] instead to resolve the introduction node
 /// first with a [`ReadOnlyNetworkGraph`].