Skip to content

Commit 49a706d

Browse files
committed
f Address comments from val
1 parent 5571e68 commit 49a706d

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

lightning/src/ln/channelmanager.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1844,9 +1844,9 @@ impl<ChanSigner: ChannelKeys, M: Deref, T: Deref, K: Deref, F: Deref> ChannelMan
18441844
let removed_source = channel_state.as_mut().unwrap().claimable_htlcs.remove(&(payment_hash, *payment_secret));
18451845
if let Some(mut sources) = removed_source {
18461846
assert!(!sources.is_empty());
1847-
let passes_value = if let &Some(ref data) = &sources[0].payment_data {
1847+
let valid_mpp_amount = if let &Some(ref data) = &sources[0].payment_data {
18481848
assert!(payment_secret.is_some());
1849-
if data.total_msat == expected_amount { true } else { false }
1849+
data.total_msat == expected_amount
18501850
} else {
18511851
assert!(payment_secret.is_none());
18521852
false
@@ -1855,7 +1855,7 @@ impl<ChanSigner: ChannelKeys, M: Deref, T: Deref, K: Deref, F: Deref> ChannelMan
18551855
let mut one_claimed = false;
18561856
for htlc in sources.drain(..) {
18571857
if channel_state.is_none() { channel_state = Some(self.channel_state.lock().unwrap()); }
1858-
if !passes_value && (htlc.value < expected_amount || htlc.value > expected_amount * 2) {
1858+
if !valid_mpp_amount && (htlc.value < expected_amount || htlc.value > expected_amount * 2) {
18591859
let mut htlc_msat_data = byte_utils::be64_to_array(htlc.value).to_vec();
18601860
let mut height_data = byte_utils::be32_to_array(self.latest_block_height.load(Ordering::Acquire) as u32).to_vec();
18611861
htlc_msat_data.append(&mut height_data);

0 commit comments

Comments
 (0)