f clean up bool setting

Author: TheBlueMatt

fuzz/src/chanmon_consistency.rs

@@ -616,10 +616,9 @@ pub fn do_test<Out: test_logger::Output>(data: &[u8], out: Out) {
 							for dest in nodes.iter() {
 								if dest.get_our_node_id() == node_id {
 									assert!(update_fee.is_none());
-									let mut processed_change = false;
-									for update_add in update_add_htlcs {
+									for update_add in update_add_htlcs.iter() {
 										if !$corrupt_forward {
-											dest.handle_update_add_htlc(&nodes[$node].get_our_node_id(), &update_add);
+											dest.handle_update_add_htlc(&nodes[$node].get_our_node_id(), update_add);
 										} else {
 											// Corrupt the update_add_htlc message so that its HMAC
 											// check will fail and we generate a
@@ -630,20 +629,18 @@ pub fn do_test<Out: test_logger::Output>(data: &[u8], out: Out) {
 											let new_msg = UpdateAddHTLC::read(&mut Cursor::new(&msg_ser)).unwrap();
 											dest.handle_update_add_htlc(&nodes[$node].get_our_node_id(), &new_msg);
 										}
-										processed_change = true;
 									}
-									for update_fulfill in update_fulfill_htlcs {
-										dest.handle_update_fulfill_htlc(&nodes[$node].get_our_node_id(), &update_fulfill);
-										processed_change = true;
+									for update_fulfill in update_fulfill_htlcs.iter() {
+										dest.handle_update_fulfill_htlc(&nodes[$node].get_our_node_id(), update_fulfill);
 									}
-									for update_fail in update_fail_htlcs {
-										dest.handle_update_fail_htlc(&nodes[$node].get_our_node_id(), &update_fail);
-										processed_change = true;
+									for update_fail in update_fail_htlcs.iter() {
+										dest.handle_update_fail_htlc(&nodes[$node].get_our_node_id(), update_fail);
 									}
-									for update_fail_malformed in update_fail_malformed_htlcs {
-										dest.handle_update_fail_malformed_htlc(&nodes[$node].get_our_node_id(), &update_fail_malformed);
-										processed_change = true;
+									for update_fail_malformed in update_fail_malformed_htlcs.iter() {
+										dest.handle_update_fail_malformed_htlc(&nodes[$node].get_our_node_id(), update_fail_malformed);
 									}
+									let processed_change = !update_add_htlcs.is_empty() || !update_fulfill_htlcs.is_empty() ||
+										!update_fail_htlcs.is_empty() || !update_fail_malformed_htlcs.is_empty();
 									if $limit_events != ProcessMessages::AllMessages && processed_change {
 										// If we only want to process some messages, don't deliver the CS until later.
 										extra_ev = Some(events::MessageSendEvent::UpdateHTLCs { node_id, updates: CommitmentUpdate {