Skip to content

Commit 6a2bbe2

Browse files
committed
Minor comments added, review
1 parent 3a5c8b3 commit 6a2bbe2

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

lightning/src/ln/channel.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2205,6 +2205,7 @@ impl<SP: Deref> PendingV2Channel<SP> where SP::Target: SignerProvider {
22052205
let change_output_weight = get_output_weight(&change_output.script_pubkey).to_wu();
22062206
let change_output_fee = fee_for_weight(self.dual_funding_context.funding_feerate_sat_per_1000_weight, change_output_weight);
22072207
change_output.value = Amount::from_sat(change_value.saturating_sub(change_output_fee));
2208+
// Note: dust check not done here, should be handled before
22082209
funding_outputs.push(OutputOwned::Single(change_output));
22092210
}
22102211

lightning/src/ln/interactivetxs.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1694,6 +1694,7 @@ pub(super) fn calculate_change_output_value(
16941694
let total_input_satoshis: u64 =
16951695
funding_inputs_prev_outputs.iter().map(|out| out.value.to_sat()).sum();
16961696

1697+
// Note: in case of additional outputs, they will have to be subtracted here
16971698
let remaining_value =
16981699
total_input_satoshis.saturating_sub(our_contribution).saturating_sub(fees_sats);
16991700

0 commit comments

Comments
 (0)