make probe_results mutable

Author: alexanderwiederin

lightning/src/ln/functional_test_utils.rs

@@ -2098,9 +2098,8 @@ pub fn expect_channel_ready_event<'a, 'b, 'c, 'd>(node: &'a Node<'b, 'c, 'd>, ex
 }
 
 #[cfg(any(test, feature = "_test_utils"))]
-pub fn expect_probe_successful_events(node: &Node, probe_results: &Vec<(PaymentHash, PaymentId)>) {
+pub fn expect_probe_successful_events(node: &Node, mut probe_results: Vec<(PaymentHash, PaymentId)>) {
 	let mut events = node.node.get_and_clear_pending_events();
-	let mut probe_results = probe_results.clone();
 
 	for event in events.drain(..) {
 		match event {

lightning/src/ln/payment_tests.rs

@@ -1286,7 +1286,7 @@ fn successful_probe_yields_event() {
 
 	pass_probe_along_route(&nodes[0], expected_route);
 
-	expect_probe_successful_events(&nodes[0], &vec![res]);
+	expect_probe_successful_events(&nodes[0], vec![res]);
 
 	assert!(!nodes[0].node.has_pending_payments());
 }
@@ -1429,7 +1429,7 @@ fn preflight_probes_yield_event_skip_private_hop() {
 
 	pass_probe_along_route(&nodes[0], expected_route);
 
-	expect_probe_successful_events(&nodes[0], &res);
+	expect_probe_successful_events(&nodes[0], res.clone());
 
 	assert!(!nodes[0].node.has_pending_payments());
 }
@@ -1475,7 +1475,8 @@ fn preflight_probes_yield_event() {
 
 	pass_probe_along_route(&nodes[0], expected_route);
 
-	expect_probe_successful_events(&nodes[0], &res);
+	expect_probe_successful_events(&nodes[0], res.clone());
+	assert_eq!(res.len(), 2);
 
 	assert!(!nodes[0].node.has_pending_payments());
 }
@@ -1523,7 +1524,7 @@ fn preflight_probes_yield_event_and_skip() {
 
 	pass_probe_along_route(&nodes[0], expected_route);
 
-	expect_probe_successful_events(&nodes[0], &res);
+	expect_probe_successful_events(&nodes[0], res.clone());
 
 	assert!(!nodes[0].node.has_pending_payments());
 }