Skip to content

Commit 7cfb09c

Browse files
committed
Add TODO noting confusion over |20 (channel_disabled) definition
1 parent 4839ef7 commit 7cfb09c

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

src/ln/channelmanager.rs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2087,6 +2087,11 @@ impl ChannelManager {
20872087
channel_id: msg.channel_id,
20882088
htlc_id: msg.htlc_id,
20892089
reason: if let Ok(update) = chan_update {
2090+
// TODO: Note that |20 is defined as "channel FROM the processing
2091+
// node has been disabled" (emphasis mine), which seems to imply
2092+
// that we can't return |20 for an inbound channel being disabled.
2093+
// This probably needs a spec update but should definitely be
2094+
// allowed.
20902095
ChannelManager::build_first_hop_failure_packet(&incoming_shared_secret, 0x1000|20, &{
20912096
let mut res = Vec::with_capacity(8 + 128);
20922097
res.extend_from_slice(&byte_utils::be16_to_array(update.contents.flags));

0 commit comments

Comments
 (0)