f Add validate_data flag

Author: tnull

lightning/src/util/persist.rs

@@ -182,12 +182,14 @@ pub trait MigratableKVStore: KVStore {
 /// might get overriden. User must ensure `source_store` is not modified during operation,
 /// otherwise no consistency guarantees can be given.
 ///
+/// Will re-read and validate the written data if `validate_data` is set.
+///
 /// Will abort and return an error if any IO operation fails. Note that in this case the
 /// `target_store` might get left in an intermediate state.
 ///
 /// **Caution**: Will delete all data from `source_store` if `move_data` is set.
 pub fn migrate_kv_store_data<S: MigratableKVStore, T: MigratableKVStore>(
-	source_store: &mut S, target_store: &mut T, move_data: bool,
+	source_store: &mut S, target_store: &mut T, validate_data: bool, move_data: bool,
 ) -> Result<(), io::Error> {
 	let keys_to_migrate = source_store.list_all_keys()?;
 
@@ -197,11 +199,13 @@ pub fn migrate_kv_store_data<S: MigratableKVStore, T: MigratableKVStore>(
 		target_store.write(primary_namespace, secondary_namespace, key, &data)?;
 
 		// Now validate what we've written.
-		let read_data = target_store.read(primary_namespace, secondary_namespace, &key)?;
-		if data != read_data {
-			let err =
-				io::Error::new(io::ErrorKind::InvalidData, "Failed to validate migrated data");
-			return Err(err);
+		if validate_data {
+			let read_data = target_store.read(primary_namespace, secondary_namespace, &key)?;
+			if data != read_data {
+				let err =
+					io::Error::new(io::ErrorKind::InvalidData, "Failed to validate migrated data");
+				return Err(err);
+			}
 		}
 	}