Skip to content

Commit 8c2a828

Browse files
committed
f Adjust PackageTemplate minimum locktime
Inline `PackageTemplate::minimum_locktime` function as it's only used once, and verify a signed locktime isn't combined with a minimum locktime.
1 parent 267046b commit 8c2a828

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

lightning/src/chain/package.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -873,13 +873,13 @@ impl PackageTemplate {
873873
signed_locktime
874874
}
875875
pub(crate) fn package_locktime(&self, current_height: u32) -> u32 {
876-
let minimum_locktime = self.inputs.iter().filter_map(|(_, outp)| outp.minimum_locktime()).max().unwrap_or(0);
876+
let minimum_locktime = self.inputs.iter().filter_map(|(_, outp)| outp.minimum_locktime()).max();
877877

878878
if let Some(signed_locktime) = self.signed_locktime() {
879-
debug_assert!(signed_locktime >= minimum_locktime);
879+
debug_assert!(minimum_locktime.is_none());
880880
signed_locktime
881881
} else {
882-
core::cmp::max(current_height, minimum_locktime)
882+
core::cmp::max(current_height, minimum_locktime.unwrap_or(0))
883883
}
884884
}
885885
pub(crate) fn package_weight(&self, destination_script: &Script) -> u64 {

0 commit comments

Comments
 (0)