f - Rename AlwaysPresent to Eternity as the former has two meanings

Author: jkczyz

lightning/src/routing/scorer.rs

@@ -80,7 +80,13 @@ pub struct ScoringParameters {
 	/// [`failure_penalty_half_life`]: Self::failure_penalty_half_life
 	pub failure_penalty_msat: u64,
 
-	/// The time needed before any accumulated channel failure penalties are cut in half.
+	/// The time required to elapse before any accumulated channel failure penalties are cut in
+	/// half.
+	///
+	/// # Note
+	///
+	/// When time is an [`Eternity`], as is default when enabling feature `no-std`, it will never
+	/// elapse. Therefore, this penalty will never decay.
 	pub failure_penalty_half_life: Duration,
 }
 
@@ -194,10 +200,10 @@ impl Clock for std::time::Instant {
 	}
 }
 
-/// A clock that is always present, now or after time has passed.
-pub struct AlwaysPresent;
+/// A state in which time has no meaning.
+pub struct Eternity;
 
-impl Clock for AlwaysPresent {
+impl Clock for Eternity {
 	fn now() -> Self {
 		Self
 	}

lightning/src/util/test_utils.rs

@@ -21,7 +21,7 @@ use ln::features::{ChannelFeatures, InitFeatures};
 use ln::msgs;
 use ln::msgs::OptionalField;
 use ln::script::ShutdownScript;
-use routing::scorer::{AlwaysPresent, Scorer};
+use routing::scorer::{Eternity, Scorer};
 use util::enforcing_trait_impls::{EnforcingSigner, EnforcementState};
 use util::events;
 use util::logger::{Logger, Level, Record};
@@ -693,4 +693,4 @@ impl core::fmt::Debug for OnRegisterOutput {
 }
 
 /// A scorer useful in testing, when the passage of time isn't a concern.
-pub type TestScorer = Scorer<AlwaysPresent>;
+pub type TestScorer = Scorer<Eternity>;