Skip to content

Commit 9cbb4e2

Browse files
committed
Re-export bitcoin crate
For the same reason the `bitcoin` crate is re-exporting the `secp256k1` crate the `lightning` crate should re-export the `bitcoin` crate: to ease the burden on calling code to maintain compatible `bitcoin` versions. The `lightning` crate makes heavy use of types defined in (or re-exported by) the `bitcoin` crate. Compilation will fail if e.g. comparisons or `match` expressions are done with types from `bitcoin` crate versions with a non-equal minor version. This forces calling code to depend on a `bitcoin` crate with a compatible version. This becomes a maintenance nightmare once two or more crates, that use `bitcoin` types in their public API, are used in calling code simultaneously.
1 parent 1237abf commit 9cbb4e2

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lightning/src/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ compile_error!("Tests will always fail with cfg=fuzzing");
6161

6262
#[macro_use]
6363
extern crate alloc;
64-
extern crate bitcoin;
64+
pub extern crate bitcoin;
6565
#[cfg(any(test, feature = "std"))]
6666
extern crate core;
6767

0 commit comments

Comments
 (0)