Merge pull request #3272 from TheBlueMatt/2024-08-bindings-hidden

Mark new `types` `#[doc(hidden)]` methods as bindings no-export

Author: TheBlueMatt

lightning-types/src/features.rs

@@ -703,6 +703,8 @@ impl InitFeatures {
 	#[doc(hidden)]
 	/// Converts `InitFeatures` to `Features<C>`. Only known `InitFeatures` relevant to context `C`
 	/// are included in the result.
+	///
+	/// This is not exported to bindings users as it shouldn't be used outside of LDK
 	pub fn to_context<C: sealed::Context>(&self) -> Features<C> {
 		self.to_context_internal()
 	}
@@ -712,6 +714,8 @@ impl Bolt11InvoiceFeatures {
 	#[doc(hidden)]
 	/// Converts `Bolt11InvoiceFeatures` to `Features<C>`. Only known `Bolt11InvoiceFeatures` relevant to
 	/// context `C` are included in the result.
+	///
+	/// This is not exported to bindings users as it shouldn't be used outside of LDK
 	pub fn to_context<C: sealed::Context>(&self) -> Features<C> {
 		self.to_context_internal()
 	}
@@ -737,15 +741,19 @@ impl Bolt12InvoiceFeatures {
 	#[doc(hidden)]
 	/// Converts [`Bolt12InvoiceFeatures`] to [`Features<C>`]. Only known [`Bolt12InvoiceFeatures`]
 	/// relevant to context `C` are included in the result.
+	///
+	/// This is not exported to bindings users as it shouldn't be used outside of LDK
 	pub fn to_context<C: sealed::Context>(&self) -> Features<C> {
 		self.to_context_internal()
 	}
 }
 
 impl ChannelTypeFeatures {
 	#[doc(hidden)]
-	// Maps the relevant `InitFeatures` to `ChannelTypeFeatures`. Any unknown features to
-	// `ChannelTypeFeatures` are not included in the result.
+	/// Maps the relevant `InitFeatures` to `ChannelTypeFeatures`. Any unknown features to
+	/// `ChannelTypeFeatures` are not included in the result.
+	///
+	/// This is not exported to bindings users as it shouldn't be used outside of LDK
 	pub fn from_init(init: &InitFeatures) -> Self {
 		let mut ret = init.to_context_internal();
 		// ChannelTypeFeatures must only contain required bits, so we OR the required forms of all

lightning/src/io/mod.rs

@@ -1,6 +1,9 @@
 pub use bitcoin::io::*;
 
 /// Emulation of std::io::Cursor
+///
+/// This is not exported to bindings users as serialization is done via a bindings-specific
+/// pipeline.
 #[derive(Clone, Debug, Default, Eq, PartialEq)]
 pub struct Cursor<T> {
 	inner: T,