Skip to content

Commit a0fe131

Browse files
committed
Refer to channels busy with funding tx negotiation as "unfunded"
We had some inconsistencies so far in referring to channels such as `OutboundV1Channel` and `InboundV1Channel` as pending and unfunded. From here we refer to these kinds of channels only as "unfunded". This is a slight conflation with the term "unfunded" in the contexts of denial of service mitigation. There, "unfunded" actually refers to non-0conf, inbound channels that have not had their funding transaction confirmed. This might warrant changing that usage to "unconfirmed inbound".
1 parent c5c5f3f commit a0fe131

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lightning/src/ln/channelmanager.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -685,7 +685,7 @@ impl <Signer: ChannelSigner> PeerState<Signer> {
685685
&& self.in_flight_monitor_updates.is_empty()
686686
}
687687

688-
// Returns a count of all channels we have with this peer, including pending channels.
688+
// Returns a count of all channels we have with this peer, including unfunded channels.
689689
fn total_channel_count(&self) -> usize {
690690
self.channel_by_id.len() +
691691
self.outbound_v1_channel_by_id.len() +

0 commit comments

Comments
 (0)