f Switch to prepare_cached statements everywhere

Author: tnull

lightning-persister/src/sqlite_store.rs

@@ -98,9 +98,13 @@ impl KVStore for SqliteStore {
 		let sql =
 			format!("SELECT value FROM {} WHERE namespace=:namespace AND key=:key;", self.kv_table_name);
 
-		let res = locked_conn
+		let mut stmt = locked_conn.prepare_cached(&sql).map_err(|e| {
+			let msg = format!("Failed to prepare statement: {}", e);
+			std::io::Error::new(std::io::ErrorKind::Other, msg)
+		})?;
+
+		let res = stmt
 			.query_row(
-				&sql,
 				named_params! {
 					":namespace": namespace,
 					":key": key,
@@ -146,14 +150,17 @@ impl KVStore for SqliteStore {
 			self.kv_table_name
 		);
 
-		locked_conn
-			.execute(
-				&sql,
-				named_params! {
-					":namespace": namespace,
-					":key": key,
-					":value": buf,
-				},
+		let mut stmt = locked_conn.prepare_cached(&sql).map_err(|e| {
+			let msg = format!("Failed to prepare statement: {}", e);
+			std::io::Error::new(std::io::ErrorKind::Other, msg)
+		})?;
+
+		stmt.execute(
+			named_params! {
+				":namespace": namespace,
+				":key": key,
+				":value": buf,
+			},
 			)
 			.map(|_| ())
 			.map_err(|e| {
@@ -183,13 +190,17 @@ impl KVStore for SqliteStore {
 		let locked_conn = self.connection.lock().unwrap();
 
 		let sql = format!("DELETE FROM {} WHERE namespace=:namespace AND key=:key;", self.kv_table_name);
-		locked_conn
-			.execute(
-				&sql,
-				named_params! {
-					":namespace": namespace,
-					":key": key,
-				},
+
+		let mut stmt = locked_conn.prepare_cached(&sql).map_err(|e| {
+			let msg = format!("Failed to prepare statement: {}", e);
+			std::io::Error::new(std::io::ErrorKind::Other, msg)
+		})?;
+
+		stmt.execute(
+			named_params! {
+				":namespace": namespace,
+				":key": key,
+			},
 			)
 			.map_err(|e| {
 				let msg = format!("Failed to delete key {}/{}: {}", namespace, key, e);
@@ -202,7 +213,7 @@ impl KVStore for SqliteStore {
 		let locked_conn = self.connection.lock().unwrap();
 
 		let sql = format!("SELECT key FROM {} WHERE namespace=:namespace", self.kv_table_name);
-		let mut stmt = locked_conn.prepare(&sql).map_err(|e| {
+		let mut stmt = locked_conn.prepare_cached(&sql).map_err(|e| {
 			let msg = format!("Failed to prepare statement: {}", e);
 			std::io::Error::new(std::io::ErrorKind::Other, msg)
 		})?;