f - Remove duplicate header validation in tests

Blockchain::tip() already returns a ValidatedBlockHeader. No need to
revalidate it via inadvertently Deref coercing back to BlockHeaderData.

Author: jkczyz

lightning-block-sync/src/poll.rs

@@ -300,10 +300,7 @@ mod tests {
 
 		// Change the nonce to get a different block hash with the same chainwork.
 		chain.blocks.last_mut().unwrap().header.nonce += 1;
-
 		let worse_chain_tip = chain.tip();
-		let worse_chain_tip_hash = worse_chain_tip.header.block_hash();
-		let worse_chain_tip = worse_chain_tip.validate(worse_chain_tip_hash).unwrap();
 		assert_eq!(best_known_chain_tip.chainwork, worse_chain_tip.chainwork);
 
 		let mut poller = ChainPoller::new(&mut chain as &mut dyn BlockSource, Network::Bitcoin);
@@ -317,11 +314,9 @@ mod tests {
 	async fn poll_chain_with_worse_tip() {
 		let mut chain = Blockchain::default().with_height(1);
 		let best_known_chain_tip = chain.tip();
-		chain.disconnect_tip();
 
+		chain.disconnect_tip();
 		let worse_chain_tip = chain.tip();
-		let worse_chain_tip_hash = worse_chain_tip.header.block_hash();
-		let worse_chain_tip = worse_chain_tip.validate(worse_chain_tip_hash).unwrap();
 
 		let mut poller = ChainPoller::new(&mut chain as &mut dyn BlockSource, Network::Bitcoin);
 		match poller.poll_chain_tip(best_known_chain_tip).await {
@@ -336,8 +331,6 @@ mod tests {
 		let best_known_chain_tip = chain.at_height(0);
 
 		let better_chain_tip = chain.tip();
-		let better_chain_tip_hash = better_chain_tip.header.block_hash();
-		let better_chain_tip = better_chain_tip.validate(better_chain_tip_hash).unwrap();
 
 		let mut poller = ChainPoller::new(&mut chain as &mut dyn BlockSource, Network::Bitcoin);
 		match poller.poll_chain_tip(best_known_chain_tip).await {