f don't reply on static invoice handling fail

Author: valentinewallace

lightning/src/ln/channelmanager.rs

@@ -4135,17 +4135,15 @@ where
 	#[cfg(async_payments)]
 	fn initiate_async_payment(
 		&self, invoice: &StaticInvoice, payment_id: PaymentId
-	) -> Result<(), InvoiceError> {
-		if invoice.message_paths().is_empty() { return Err(Bolt12SemanticError::MissingPaths.into()) }
-
+	) -> Result<(), Bolt12PaymentError> {
 		let reply_path = self.create_blinded_path(
 			MessageContext::AsyncPayments(AsyncPaymentsContext::OutboundPayment { payment_id })
-		).map_err(|_| Bolt12SemanticError::MissingPaths)?;
+		).map_err(|_| Bolt12PaymentError::BlindedPathNotFound)?;
 
 		let _persistence_guard = PersistenceNotifierGuard::notify_on_drop(self);
 		let payment_release_secret = self.pending_outbound_payments.static_invoice_received(
 			invoice, payment_id, &*self.entropy_source
-		).map_err(|e| InvoiceError::from_string(format!("{:?}", e)))?;
+		)?;
 
 		let mut pending_async_payments_messages = self.pending_async_payments_messages.lock().unwrap();
 		const HTLC_AVAILABLE_LIMIT: usize = 10;
@@ -10684,22 +10682,16 @@ where
 			},
 			#[cfg(async_payments)]
 			OffersMessage::StaticInvoice(invoice) => {
-				let responder = match responder {
-					Some(responder) => responder,
-					None => return ResponseInstruction::NoResponse,
-				};
 				let payment_id = match context {
 					OffersContext::OutboundPayment { payment_id } => payment_id,
 					_ => {
-						return responder.respond(OffersMessage::InvoiceError(
-								InvoiceError::from_string("Unrecognized invoice".to_string())
-						))
+						return ResponseInstruction::NoResponse
 					}
 				};
-				match self.initiate_async_payment(&invoice, payment_id) {
-					Ok(()) => return ResponseInstruction::NoResponse,
-					Err(e) => responder.respond(OffersMessage::InvoiceError(e)),
+				if let Err(e) = self.initiate_async_payment(&invoice, payment_id) {
+					log_trace!(self.logger, "Failed to initiate async payment to static invoice: {:?}", e);
 				}
+				ResponseInstruction::NoResponse
 			},
 			OffersMessage::InvoiceError(invoice_error) => {
 				abandon_if_payment(context);

lightning/src/ln/outbound_payment.rs

@@ -531,6 +531,8 @@ pub enum Bolt12PaymentError {
 	///
 	/// [`BlindedPath`]: crate::blinded_path::BlindedPath
 	OnionPacketSizeExceeded,
+	/// Failed to create a blinded path.
+	BlindedPathNotFound,
 }
 
 /// Indicates that we failed to send a payment probe. Further errors may be surfaced later via