Skip to content

Commit ab60bcc

Browse files
committed
Correct syn pinning on cargo 1.48
Sadly the pinning introduced in 050f5a9 was brittle in the face of any further syn updates, and has already broken. Here we fix it by looking up the actual version of syn to pin. Note that this dependency is somewhat nonsense as its actually only a `criterion` dependency, pulled in even though we haven't set the bench flag (as we aren't yet using `resolver = 2`).
1 parent 6d5c5ba commit ab60bcc

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

ci/ci-tests.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,8 @@ PIN_RELEASE_DEPS # pin the release dependencies in our main workspace
3030
[ "$RUSTC_MINOR_VERSION" -lt 56 ] && cargo update -p quote --precise "1.0.30" --verbose
3131

3232
# The syn crate depends on too-new proc-macro2 starting with v2.0.33, i.e., has MSRV of 1.56
33-
[ "$RUSTC_MINOR_VERSION" -lt 56 ] && cargo update -p syn:2.0.33 --precise "2.0.32" --verbose
33+
SYN_2_DEP=$(cat Cargo.lock | grep -o '"syn 2.*' | tr -d '",' | tr ' ' ':')
34+
[ "$RUSTC_MINOR_VERSION" -lt 56 ] && cargo update -p $SYN_2_DEP --precise "2.0.32" --verbose
3435

3536
# The proc-macro2 crate switched to Rust edition 2021 starting with v1.0.66, i.e., has MSRV of 1.56
3637
[ "$RUSTC_MINOR_VERSION" -lt 56 ] && cargo update -p proc-macro2 --precise "1.0.65" --verbose

0 commit comments

Comments
 (0)