f Detect inconsistency if previously-confirmed Tx is now unconfirmed

Author: tnull

lightning-transaction-sync/src/esplora.rs

@@ -285,8 +285,15 @@ where
 				if let Some(spending_txid) = output_status.txid {
 					if let Some(spending_tx_status) = output_status.status {
 						if confirmed_txs.iter().any(|ctx| ctx.tx.txid() == spending_txid) {
-							continue;
+							if spending_tx_status.confirmed {
+								// Skip inserting duplicate ConfirmedTx entry
+								continue;
+							} else {
+								log_trace!(self.logger, "Inconsistency: Detected previously-confirmed Tx {} as unconfirmed", spending_txid);
+								return Err(InternalError::Inconsistency);
+							}
 						}
+
 						if let Some(confirmed_tx) = maybe_await!(self
 							.get_confirmed_tx(
 								&spending_txid,