Merge pull request #3095 from TheBlueMatt/2024-06-tx-sync-bindings-upstream

Mark BDK types exported from transaction-sync as no-export

Author: valentinewallace

lightning-transaction-sync/src/electrum.rs

@@ -58,6 +58,8 @@ where
 	}
 
 	/// Returns a new [`ElectrumSyncClient`] object using the given Electrum client.
+	///
+	/// This is not exported to bindings users as the underlying client from BDK is not exported.
 	pub fn from_client(client: ElectrumClient, logger: L) -> Result<Self, TxSyncError> {
 		let sync_state = Mutex::new(SyncState::new());
 		let queue = Mutex::new(FilterQueue::new());
@@ -450,6 +452,8 @@ where
 	}
 
 	/// Returns a reference to the underlying Electrum client.
+	///
+	/// This is not exported to bindings users as the underlying client from BDK is not exported.
 	pub fn client(&self) -> &ElectrumClient {
 		&self.client
 	}

lightning-transaction-sync/src/esplora.rs

@@ -59,6 +59,8 @@ where
 	}
 
 	/// Returns a new [`EsploraSyncClient`] object using the given Esplora client.
+	///
+	/// This is not exported to bindings users as the underlying client from BDK is not exported.
 	pub fn from_client(client: EsploraClientType, logger: L) -> Self {
 		let sync_state = MutexType::new(SyncState::new());
 		let queue = std::sync::Mutex::new(FilterQueue::new());
@@ -397,6 +399,8 @@ where
 	}
 
 	/// Returns a reference to the underlying esplora client.
+	///
+	/// This is not exported to bindings users as the underlying client from BDK is not exported.
 	pub fn client(&self) -> &EsploraClientType {
 		&self.client
 	}