Skip to content

Commit b3676c6

Browse files
committed
Drop address ordering enforcement in NodeAnnouncement deser
It seems many other nodes never bothered to enforce these requirements, so there's little reason that we should either. cc lightning/bolts#842
1 parent 879e309 commit b3676c6

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

lightning/src/ln/msgs.rs

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1562,19 +1562,13 @@ impl Readable for UnsignedNodeAnnouncement {
15621562

15631563
let addr_len: u16 = Readable::read(r)?;
15641564
let mut addresses: Vec<NetAddress> = Vec::new();
1565-
let mut highest_addr_type = 0;
15661565
let mut addr_readpos = 0;
15671566
let mut excess = false;
15681567
let mut excess_byte = 0;
15691568
loop {
15701569
if addr_len <= addr_readpos { break; }
15711570
match Readable::read(r) {
15721571
Ok(Ok(addr)) => {
1573-
if addr.get_id() < highest_addr_type {
1574-
// Addresses must be sorted in increasing order
1575-
return Err(DecodeError::InvalidValue);
1576-
}
1577-
highest_addr_type = addr.get_id();
15781572
if addr_len < addr_readpos + 1 + addr.len() {
15791573
return Err(DecodeError::BadLengthDescriptor);
15801574
}

0 commit comments

Comments
 (0)