Removing the outer loop on the iterator for the zip_nested_vectors

function

- breaking from the inner loop was an unnecessary addition

Author: upjohnc

lightning-invoice/src/utils.rs

@@ -287,27 +287,23 @@ fn zip_nested_vectors<T: Clone>(vecs: Vec<Vec<T>>, result_size: usize) -> impl I
     let mut total_hints_returned = 0;
 
     core::iter::from_fn(move || loop {
-        let return_value = loop {
-            if total_hints_returned == result_size || hint_index == max_vector_length {
-                break None;
-            };
-            let hint_value =
-                if vecs[vector_index].len() != 0 && vecs[vector_index].len() > hint_index {
-                    Some(vecs[vector_index][hint_index].clone())
-                } else {
-                    None // no value retrieved - continue looping
-                };
-            vector_index += 1;
-            if hint_index < max_vector_length && vector_index == number_inner_vectors {
-                vector_index = 0;
-                hint_index += 1;
-            };
-            if !hint_value.is_none() {
-                total_hints_returned += 1;
-                break hint_value;
-            };
+        if total_hints_returned == result_size || hint_index == max_vector_length {
+            return None;
+        };
+        let hint_value = if vecs[vector_index].len() != 0 && vecs[vector_index].len() > hint_index {
+            Some(vecs[vector_index][hint_index].clone())
+        } else {
+            None // no value retrieved - continue looping
+        };
+        vector_index += 1;
+        if hint_index < max_vector_length && vector_index == number_inner_vectors {
+            vector_index = 0;
+            hint_index += 1;
+        };
+        if !hint_value.is_none() {
+            total_hints_returned += 1;
+            return hint_value;
         };
-        return return_value;
     })
 }