f remove 'let _ =' for state transitions

Author: dunxen

lightning/src/ln/interactivetxs.rs

@@ -456,7 +456,7 @@ macro_rules! define_state_transitions {
 			impl<S: LocalState> StateTransition<ReceivedChange, $data> for S {
 				fn transition(self, data: $data) -> StateTransitionResult<ReceivedChange> {
 					let mut context = self.into_negotiation_context();
-					let _ = context.$transition(data)?;
+					context.$transition(data)?;
 					Ok(ReceivedChange(context))
 				}
 			}
@@ -467,7 +467,7 @@ macro_rules! define_state_transitions {
 			impl<S: RemoteState> StateTransition<SentChange, $data> for S {
 				fn transition(self, data: $data) -> StateTransitionResult<SentChange> {
 					let mut context = self.into_negotiation_context();
-					let _ = context.$transition(data);
+					context.$transition(data);
 					Ok(SentChange(context))
 				}
 			}
@@ -706,7 +706,7 @@ impl InteractiveTxConstructor {
 				prevtx_out: input.previous_output.vout,
 				sequence: input.sequence.to_consensus_u32(),
 			};
-			let _ = do_state_transition!(self, sent_tx_add_input, &msg)?;
+			do_state_transition!(self, sent_tx_add_input, &msg)?;
 			Ok(InteractiveTxMessageSend::TxAddInput(msg))
 		} else if let Some((serial_id, output)) = self.outputs_to_contribute.pop() {
 			let msg = msgs::TxAddOutput {
@@ -715,47 +715,47 @@ impl InteractiveTxConstructor {
 				sats: output.value,
 				script: output.script_pubkey,
 			};
-			let _ = do_state_transition!(self, sent_tx_add_output, &msg)?;
+			do_state_transition!(self, sent_tx_add_output, &msg)?;
 			Ok(InteractiveTxMessageSend::TxAddOutput(msg))
 		} else {
 			let msg = msgs::TxComplete { channel_id: self.channel_id };
-			let _ = do_state_transition!(self, sent_tx_complete, &msg)?;
+			do_state_transition!(self, sent_tx_complete, &msg)?;
 			Ok(InteractiveTxMessageSend::TxComplete(msg))
 		}
 	}
 
 	pub fn handle_tx_add_input(
 		&mut self, msg: &msgs::TxAddInput,
 	) -> Result<InteractiveTxMessageSend, AbortReason> {
-		let _ = do_state_transition!(self, received_tx_add_input, msg)?;
+		do_state_transition!(self, received_tx_add_input, msg)?;
 		self.do_local_state_transition()
 	}
 
 	pub fn handle_tx_remove_input(
 		&mut self, msg: &msgs::TxRemoveInput,
 	) -> Result<InteractiveTxMessageSend, AbortReason> {
-		let _ = do_state_transition!(self, received_tx_remove_input, msg)?;
+		do_state_transition!(self, received_tx_remove_input, msg)?;
 		self.do_local_state_transition()
 	}
 
 	pub fn handle_tx_add_output(
 		&mut self, msg: &msgs::TxAddOutput,
 	) -> Result<InteractiveTxMessageSend, AbortReason> {
-		let _ = do_state_transition!(self, received_tx_add_output, msg)?;
+		do_state_transition!(self, received_tx_add_output, msg)?;
 		self.do_local_state_transition()
 	}
 
 	pub fn handle_tx_remove_output(
 		&mut self, msg: &msgs::TxRemoveOutput,
 	) -> Result<InteractiveTxMessageSend, AbortReason> {
-		let _ = do_state_transition!(self, received_tx_remove_output, msg)?;
+		do_state_transition!(self, received_tx_remove_output, msg)?;
 		self.do_local_state_transition()
 	}
 
 	pub fn handle_tx_complete(
 		&mut self, msg: &msgs::TxComplete,
 	) -> Result<(Option<InteractiveTxMessageSend>, Option<Transaction>), AbortReason> {
-		let _ = do_state_transition!(self, received_tx_complete, msg)?;
+		do_state_transition!(self, received_tx_complete, msg)?;
 		match &self.state_machine {
 			StateMachine::ReceivedTxComplete(_) => {
 				let msg_send = self.do_local_state_transition()?;