f use AtomicBool

Author: TheBlueMatt

lightning/src/ln/peer_handler.rs

@@ -1305,8 +1305,8 @@ mod tests {
 		// Create 2 peers with custom TestRoutingMessageHandlers and connect them.
 		let (chan_handlers, routing_handlers) = create_chan_handlers(2);
 		let peers = create_network(2, &chan_handlers, &routing_handlers);
-		routing_handlers[0].request_full_sync.store(1, Ordering::Release);
-		routing_handlers[1].request_full_sync.store(1, Ordering::Release);
+		routing_handlers[0].request_full_sync.store(true, Ordering::Release);
+		routing_handlers[1].request_full_sync.store(true, Ordering::Release);
 
 		// By calling establish_connect, we trigger do_attempt_write_data between
 		// the peers. Previously this function would mistakenly enter an infinite loop
@@ -1333,7 +1333,7 @@ mod tests {
 		// Inbound peer 0 requests initial_routing_sync, but outbound peer 1 does not.
 		{
 			let (chan_handlers, routing_handlers) = create_chan_handlers(2);
-			routing_handlers[0].request_full_sync.store(1, Ordering::Release);
+			routing_handlers[0].request_full_sync.store(true, Ordering::Release);
 			let peers = create_network(2, &chan_handlers, &routing_handlers);
 			let (fd_0_to_1, fd_1_to_0) = establish_connection_and_read_events(&peers[0], &peers[1]);
 
@@ -1350,7 +1350,7 @@ mod tests {
 		// Outbound peer 1 requests initial_routing_sync, but inbound peer 0 does not.
 		{
 			let (chan_handlers, routing_handlers) = create_chan_handlers(2);
-			routing_handlers[1].request_full_sync.store(1, Ordering::Release);
+			routing_handlers[1].request_full_sync.store(true, Ordering::Release);
 			let peers = create_network(2, &chan_handlers, &routing_handlers);
 			let (fd_0_to_1, fd_1_to_0) = establish_connection_and_read_events(&peers[0], &peers[1]);
 

lightning/src/util/test_utils.rs

@@ -25,7 +25,7 @@ use bitcoin::secp256k1::{SecretKey, PublicKey, Secp256k1, Signature};
 
 use std::time::{SystemTime, UNIX_EPOCH};
 use std::sync::{Arc,Mutex};
-use std::sync::atomic::{AtomicUsize, Ordering};
+use std::sync::atomic::{AtomicBool, AtomicUsize, Ordering};
 use std::{cmp, mem};
 use std::collections::HashMap;
 
@@ -226,7 +226,7 @@ pub struct TestRoutingMessageHandler {
 	pub chan_upds_recvd: AtomicUsize,
 	pub chan_anns_recvd: AtomicUsize,
 	pub chan_anns_sent: AtomicUsize,
-	pub request_full_sync: AtomicUsize,
+	pub request_full_sync: AtomicBool,
 }
 
 impl TestRoutingMessageHandler {
@@ -235,7 +235,7 @@ impl TestRoutingMessageHandler {
 			chan_upds_recvd: AtomicUsize::new(0),
 			chan_anns_recvd: AtomicUsize::new(0),
 			chan_anns_sent: AtomicUsize::new(0),
-			request_full_sync: AtomicUsize::new(0),
+			request_full_sync: AtomicBool::new(false),
 		}
 	}
 }
@@ -273,7 +273,7 @@ impl msgs::RoutingMessageHandler for TestRoutingMessageHandler {
 	}
 
 	fn should_request_full_sync(&self, _node_id: &PublicKey) -> bool {
-		self.request_full_sync.load(Ordering::Acquire) != 0
+		self.request_full_sync.load(Ordering::Acquire)
 	}
 }