Add tests for handling node announcements

Author: naumenkogs

lightning/src/ln/router.rs

@@ -1057,7 +1057,7 @@ mod tests {
 	use ln::channelmanager;
 	use ln::router::{Router,NodeInfo,NetworkMap,ChannelInfo,DirectionalChannelInfo,RouteHint};
 	use ln::features::{ChannelFeatures, InitFeatures, NodeFeatures};
-	use ln::msgs::{ErrorAction, LightningError, RoutingMessageHandler};
+	use ln::msgs::{ErrorAction, LightningError, RoutingMessageHandler, UnsignedNodeAnnouncement, NodeAnnouncement};
 	use util::test_utils;
 	use util::test_utils::TestVecWriter;
 	use util::logger::Logger;
@@ -1864,4 +1864,75 @@ mod tests {
 		assert!(router.should_request_full_sync(&node_id));
 		assert!(!router.should_request_full_sync(&node_id));
 	}
+
+	#[test]
+	fn handling_node_announcements() {
+		let (secp_ctx, _, router) = create_router();
+		let secret_key = &SecretKey::from_slice(&hex::decode("0202020202020202020202020202020202020202020202020202020202020202").unwrap()[..]).unwrap();
+		let node_id = PublicKey::from_secret_key(&secp_ctx, secret_key);
+		let zero_hash = Sha256dHash::hash(&[0; 32]);
+		let first_announcement_time = 500;
+
+		let mut unsigned_announcement = UnsignedNodeAnnouncement {
+			features: NodeFeatures::supported(),
+			timestamp: first_announcement_time + 1,
+			node_id,
+			rgb: [0; 3],
+			alias: [0; 32],
+			addresses: Vec::new(),
+			excess_address_data: Vec::new(),
+			excess_data: Vec::new(),
+		};
+		let mut msghash = hash_to_message!(&Sha256dHash::hash(&unsigned_announcement.encode()[..])[..]);
+		let valid_announcement = NodeAnnouncement {
+			signature: secp_ctx.sign(&msghash, secret_key),
+			contents: unsigned_announcement.clone()
+		};
+
+	 	match router.handle_node_announcement(&valid_announcement) {
+			Ok(_) => panic!(),
+			Err(e) => assert_eq!("No existing channels for node_announcement", e.err)
+		};
+
+		{
+			let mut network = router.network_map.write().unwrap();
+			network.nodes.insert(node_id.clone(), NodeInfo {
+				channels: vec!(NetworkMap::get_key(1, zero_hash.clone()), NetworkMap::get_key(3, zero_hash.clone())),
+				lowest_inbound_channel_fee_base_msat: 100,
+				lowest_inbound_channel_fee_proportional_millionths: 0,
+				features: NodeFeatures::supported(),
+				last_update: Some(first_announcement_time),
+				rgb: [0; 3],
+				alias: [0; 32],
+				addresses: Vec::new(),
+				announcement_message: None,
+			});
+		}
+
+	 	match router.handle_node_announcement(&valid_announcement) {
+			Ok(res) => assert!(res),
+			Err(e) => panic!("{}", e.err)
+		};
+
+		let fake_msghash = hash_to_message!(&zero_hash);
+		match router.handle_node_announcement(
+			&NodeAnnouncement {
+				signature: secp_ctx.sign(&fake_msghash, secret_key),
+				contents: unsigned_announcement.clone()
+		}) {
+			Ok(_) => panic!(),
+			Err(e) => assert_eq!(e.err, "Invalid signature from remote node")
+		};
+
+		unsigned_announcement.timestamp = first_announcement_time - 1;
+		msghash = hash_to_message!(&Sha256dHash::hash(&unsigned_announcement.encode()[..])[..]);
+		let outdated_announcement = NodeAnnouncement {
+			signature: secp_ctx.sign(&msghash, secret_key),
+			contents: unsigned_announcement.clone()
+		};
+	 	match router.handle_node_announcement(&outdated_announcement) {
+			Ok(_) => panic!(),
+			Err(e) => assert_eq!(e.err, "Update older than last processed update")
+		};
+	}
 }