Disallow duplicate Init messages from peers

TheBlueMatt · TheBlueMatt · commit e9fed4973b64 · 2018-09-08T14:43:42.000-04:00
diff --git a/src/ln/peer_handler.rs b/src/ln/peer_handler.rs
@@ -445,6 +445,9 @@ impl<Descriptor: SocketDescriptor> PeerManager<Descriptor> {
 												if msg.local_features.requires_unknown_bits() {
 													return Err(PeerHandleError{ no_connection_possible: true });
 												}
+												if peer.their_global_features.is_some() {
+													return Err(PeerHandleError{ no_connection_possible: false });
+												}
 												peer.their_global_features = Some(msg.global_features);
 												peer.their_local_features = Some(msg.local_features);
 

Original file line number	Diff line number	Diff line change
`@@ -445,6 +445,9 @@ impl<Descriptor: SocketDescriptor> PeerManager<Descriptor> {`
`445`	`445`	`if msg.local_features.requires_unknown_bits() {`
`446`	`446`	`return Err(PeerHandleError{ no_connection_possible: true });`
`447`	`447`	`}`
	`448`	`+ if peer.their_global_features.is_some() {`
	`449`	`+ return Err(PeerHandleError{ no_connection_possible: false });`
	`450`	`+ }`
`448`	`451`	`peer.their_global_features = Some(msg.global_features);`
`449`	`452`	`peer.their_local_features = Some(msg.local_features);`
`450`	`453`