f use AtomicBool

Author: TheBlueMatt

lightning/src/ln/peer_handler.rs

@@ -1313,8 +1313,8 @@ mod tests {
 	fn test_do_attempt_write_data() {
 		// Create 2 peers with custom TestRoutingMessageHandlers and connect them.
 		let cfgs = create_peermgr_cfgs(2);
-		cfgs[0].routing_handler.request_full_sync.store(1, Ordering::Release);
-		cfgs[1].routing_handler.request_full_sync.store(1, Ordering::Release);
+		cfgs[0].routing_handler.request_full_sync.store(true, Ordering::Release);
+		cfgs[1].routing_handler.request_full_sync.store(true, Ordering::Release);
 		let peers = create_network(2, &cfgs);
 
 		// By calling establish_connect, we trigger do_attempt_write_data between
@@ -1342,7 +1342,7 @@ mod tests {
 		// Inbound peer 0 requests initial_routing_sync, but outbound peer 1 does not.
 		{
 			let cfgs = create_peermgr_cfgs(2);
-			cfgs[0].routing_handler.request_full_sync.store(1, Ordering::Release);
+			cfgs[0].routing_handler.request_full_sync.store(true, Ordering::Release);
 			let peers = create_network(2, &cfgs);
 			let (fd_0_to_1, fd_1_to_0) = establish_connection_and_read_events(&peers[0], &peers[1]);
 
@@ -1359,7 +1359,7 @@ mod tests {
 		// Outbound peer 1 requests initial_routing_sync, but inbound peer 0 does not.
 		{
 			let cfgs = create_peermgr_cfgs(2);
-			cfgs[1].routing_handler.request_full_sync.store(1, Ordering::Release);
+			cfgs[1].routing_handler.request_full_sync.store(true, Ordering::Release);
 			let peers = create_network(2, &cfgs);
 			let (fd_0_to_1, fd_1_to_0) = establish_connection_and_read_events(&peers[0], &peers[1]);
 

lightning/src/util/test_utils.rs

@@ -24,7 +24,7 @@ use bitcoin::secp256k1::{SecretKey, PublicKey, Secp256k1, Signature};
 
 use std::time::{SystemTime, UNIX_EPOCH};
 use std::sync::Mutex;
-use std::sync::atomic::{AtomicUsize, Ordering};
+use std::sync::atomic::{AtomicBool, AtomicUsize, Ordering};
 use std::{cmp, mem};
 use std::collections::HashMap;
 
@@ -225,7 +225,7 @@ pub struct TestRoutingMessageHandler {
 	pub chan_upds_recvd: AtomicUsize,
 	pub chan_anns_recvd: AtomicUsize,
 	pub chan_anns_sent: AtomicUsize,
-	pub request_full_sync: AtomicUsize,
+	pub request_full_sync: AtomicBool,
 }
 
 impl TestRoutingMessageHandler {
@@ -234,7 +234,7 @@ impl TestRoutingMessageHandler {
 			chan_upds_recvd: AtomicUsize::new(0),
 			chan_anns_recvd: AtomicUsize::new(0),
 			chan_anns_sent: AtomicUsize::new(0),
-			request_full_sync: AtomicUsize::new(0),
+			request_full_sync: AtomicBool::new(false),
 		}
 	}
 }
@@ -272,7 +272,7 @@ impl msgs::RoutingMessageHandler for TestRoutingMessageHandler {
 	}
 
 	fn should_request_full_sync(&self, _node_id: &PublicKey) -> bool {
-		self.request_full_sync.load(Ordering::Acquire) != 0
+		self.request_full_sync.load(Ordering::Acquire)
 	}
 }