Remove default ChannelScorer impl on NetworkGraph

Author: sourabhmarathe

lightning/src/routing/network_graph.rs

@@ -437,10 +437,6 @@ pub trait ChannelScorer {
 	type Metadata;
 	/// Returns penalty fee for a given channel ID based on user's channel metadata
 	fn calculate_minimum_fee_penalty(&self, _channel_id: u64) -> u64 { 0 }
-	/// Optional: allows user to count PaymentSent events for channels
-	fn score_payment_success(&self, _route: Vec<Vec<RouteHop>>, _metadata: Vec<Self::Metadata>) {}
-	/// Optional: allows user to count PaymentFailed events for channels
-	fn score_payment_failure(&self, _route: Vec<Vec<RouteHop>>, _faulty_nodes: Vec<PublicKey>, _metadata: Vec<Self::Metadata>) {}
 }
 
 /// Represents the network as nodes and channels between them
@@ -503,13 +499,6 @@ impl std::fmt::Display for NetworkGraph {
 	}
 }
 
-/// By default, just do nothing when scoring channels. A user is free to extend these
-/// definitions to meet their needs.
-impl ChannelScorer for NetworkGraph {
-	/// The default type for Metadata is just a placeholder.
-	type Metadata = Option<u8>;
-}
-
 impl NetworkGraph {
 	/// Returns all known valid channels' short ids along with announced channel info.
 	pub fn get_channels<'a>(&'a self) -> &'a BTreeMap<u64, ChannelInfo> { &self.channels }