patch to change temp_channel from deserialise to copy #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patch to change temp_channel from deserialise to copy
TheBlueMatt
reviewed
Sep 6, 2018
src/ln/msgs.rs
Outdated
| Ok(OpenChannel { | ||
| chain_hash: deserialize(&v[0..32]).unwrap(), | ||
| temporary_channel_id: deserialize(&v[32..64]).unwrap(), | ||
| temporary_channel_id: temp_channel_id, | ||
| chain_hash: deserialize(&v[0..32])?, |
There was a problem hiding this comment.
Oops, this line was carried over from the previous change. And the next one.
There was a problem hiding this comment.
haha oops, happens when you edit in the browser, while sitting in a bus.
TheBlueMatt
added a commit
that referenced
this pull request
Sep 6, 2018
patch to change temp_channel from deserialise to copy
|
Squashed + merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am making this PR because #142 has code in it that requires more discussion and better implementation.