Skip to content

Fix outdated README sections #1693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

valentinewallace
Copy link
Contributor

No description provided.

Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚲 🏠 blue!

Copy link

@ariard ariard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice if we can finally land this one.

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2022

Codecov Report

Base: 90.88% // Head: 92.62% // Increases project coverage by +1.74% 🎉

Coverage data is based on head (21a1a45) compared to base (00f08c9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1693      +/-   ##
==========================================
+ Coverage   90.88%   92.62%   +1.74%     
==========================================
  Files          85       87       +2     
  Lines       46220    61297   +15077     
  Branches    46220    61297   +15077     
==========================================
+ Hits        42007    56777   +14770     
- Misses       4213     4520     +307     
Impacted Files Coverage Δ
lightning/src/chain/mod.rs 57.69% <0.00%> (-10.49%) ⬇️
lightning/src/util/events.rs 36.49% <0.00%> (-3.01%) ⬇️
lightning-invoice/src/utils.rs 96.08% <0.00%> (-0.70%) ⬇️
lightning-block-sync/src/init.rs 93.03% <0.00%> (-0.54%) ⬇️
lightning/src/chain/onchaintx.rs 94.71% <0.00%> (-0.23%) ⬇️
lightning/src/ln/shutdown_tests.rs 96.36% <0.00%> (-0.16%) ⬇️
lightning/src/ln/chanmon_update_fail_tests.rs 97.65% <0.00%> (-0.07%) ⬇️
lightning/src/ln/script.rs 92.13% <0.00%> (-0.06%) ⬇️
lightning/src/ln/payment_tests.rs 98.87% <0.00%> (-0.02%) ⬇️
lightning/src/lib.rs 100.00% <0.00%> (ø)
... and 43 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@valentinewallace
Copy link
Contributor Author

Nice if we can finally land this one.

Thanks for reminding me this PR exists 😅

Copy link

@ariard ariard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 21a1a45

If we can have another past reviewer looking back.

@TheBlueMatt
Copy link
Collaborator

Feel free to squash, I think.

tnull
tnull previously approved these changes Oct 6, 2022
Copy link
Contributor

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a few nits.

tnull
tnull previously approved these changes Oct 7, 2022
@jkczyz jkczyz merged commit 2fda791 into lightningdevkit:main Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants