Skip to content

Remove redundant field names #1765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gcomte
Copy link
Contributor

@gcomte gcomte commented Oct 11, 2022

Very simple refactoring, purging redundant field names

@codecov-commenter
Copy link

Codecov Report

Base: 90.78% // Head: 90.76% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (8abf02c) compared to base (fdfd4f0).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1765      +/-   ##
==========================================
- Coverage   90.78%   90.76%   -0.03%     
==========================================
  Files          87       87              
  Lines       46969    46969              
  Branches    46969    46969              
==========================================
- Hits        42643    42633      -10     
- Misses       4326     4336      +10     
Impacted Files Coverage Δ
lightning/src/chain/channelmonitor.rs 91.21% <ø> (ø)
lightning/src/routing/router.rs 91.62% <ø> (ø)
lightning/src/ln/channelmanager.rs 85.16% <100.00%> (ø)
lightning/src/ln/functional_test_utils.rs 93.44% <100.00%> (ø)
lightning/src/chain/onchaintx.rs 94.71% <0.00%> (-0.92%) ⬇️
lightning/src/ln/monitor_tests.rs 99.44% <0.00%> (-0.12%) ⬇️
lightning/src/ln/functional_tests.rs 96.87% <0.00%> (-0.08%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@valentinewallace valentinewallace merged commit 6772609 into lightningdevkit:main Oct 12, 2022
@gcomte gcomte deleted the refactor/remove-redundant-field-names branch October 14, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants