Add module and all-pub-things docs and deny missing docs #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has bitrotted a lot and doesn't really make sense given all the precondition enforcement that is in channelmanager, sadly.
TheBlueMatt
force-pushed
the
2018-09-docs-docs-docs
branch
from
ff29f46 to
3aeec96
Compare
|
I'm just gonna take this cause its (mostly) docs. Sorry about the deny(missing_docs), I'm sure that'll cause a bit of rebase pain. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds deny(missing_docs), which ends up requiring a ton of documentation, and also making some things non-pub anymore. I want to get some more API changes shoved in then tag a bump so that things look a tiny bit cleaner in the leadup to 0.1.