Skip to content

Convert Network to and from Currency #2173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

benthecarman
Copy link
Contributor

Some nice helpers

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.02 ⚠️

Comparison is base (74328bd) 91.38% compared to head (841dd1e) 91.37%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2173      +/-   ##
==========================================
- Coverage   91.38%   91.37%   -0.02%     
==========================================
  Files         102      102              
  Lines       50330    50337       +7     
  Branches    50330    50337       +7     
==========================================
- Hits        45995    45993       -2     
- Misses       4335     4344       +9     
Impacted Files Coverage Δ
lightning-invoice/src/lib.rs 79.38% <66.66%> (-0.22%) ⬇️

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@valentinewallace valentinewallace merged commit 3468669 into lightningdevkit:main Apr 10, 2023
@benthecarman benthecarman deleted the convert-currency-to-netowkr branch April 10, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants