Skip to content

Mark the invoice Network getter no-export #2195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

TheBlueMatt
Copy link
Collaborator

...as it is redundant with the currency getter if we're not using the rust-bitcoin types natively.

...as it is redundant with the `currency` getter if we're not using
the rust-bitcoin types natively.
@TheBlueMatt TheBlueMatt added this to the 0.0.115 milestone Apr 17, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.04 ⚠️

Comparison is base (1505089) 91.35% compared to head (b709bb3) 91.31%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2195      +/-   ##
==========================================
- Coverage   91.35%   91.31%   -0.04%     
==========================================
  Files         102      102              
  Lines       50463    50463              
  Branches    50463    50463              
==========================================
- Hits        46102    46082      -20     
- Misses       4361     4381      +20     
Impacted Files Coverage Δ
lightning-invoice/src/lib.rs 79.97% <ø> (ø)

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TheBlueMatt TheBlueMatt merged commit bd25a81 into lightningdevkit:main Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants