Incorporate low-R values into estimate signature size #2244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2244 +/- ##
==========================================
+ Coverage 91.56% 91.58% +0.02%
==========================================
Files 104 104
Lines 51749 51979 +230
Branches 51749 51979 +230
==========================================
+ Hits 47384 47607 +223
- Misses 4365 4372 +7
☔ View full report in Codecov by Sentry. |
TheBlueMatt
reviewed
Apr 28, 2023
benthecarman
force-pushed
the
signature-size
branch
from
4e47542 to
683102d
Compare
benthecarman
force-pushed
the
signature-size
branch
from
683102d to
0517b18
Compare
TheBlueMatt
approved these changes
May 2, 2023
wpaulino
approved these changes
May 2, 2023
jkczyz
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before it was estimating a 73 byte signature which is assuming a high-R value. If the user has the
grind_signaturesflag on we can assume they will create a low-r value signature and thus estimate with a 72 byte signature.This PR should make fee estimation slightly better.