Use PrintableString for displaying errors in PeerManager #2342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimirfomene
force-pushed
the
2023-06-use-untrustedstring-in-error-logs
branch
2 times, most recently
from
ba70a73 to
eebdfaf
Compare
TheBlueMatt
reviewed
Jun 7, 2023
vladimirfomene
force-pushed
the
2023-06-use-untrustedstring-in-error-logs
branch
from
eebdfaf to
86da719
Compare
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #2342 +/- ##
==========================================
+ Coverage 90.34% 90.40% +0.05%
==========================================
Files 104 104
Lines 53392 53771 +379
Branches 53392 53771 +379
==========================================
+ Hits 48237 48609 +372
- Misses 5155 5162 +7
☔ View full report in Codecov by Sentry. |
TheBlueMatt
reviewed
Jun 7, 2023
We currently just print "with non-ASCII error message" to log when we see non-ASCII chars, but should instead use our fancy PrintableString type to display the untrusted string and ignore control chars.
vladimirfomene
force-pushed
the
2023-06-use-untrustedstring-in-error-logs
branch
from
86da719 to
b5c89cc
Compare
jkczyz
changed the title
dunxen
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently just print "with non-ASCII error message" to log when we see non-ASCII chars, but should instead use our fancy UntrustedString wrapper to display the untrusted string and ignore control chars.
Fixes #2291