Skip to content

(Minor) Remove an unused import (ChannelSigner) #2454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

optout21
Copy link
Contributor

One-liner fix for an unused import warning.
Remove unused import sign::ChannelSigner.

Rids the following compiler warning:

warning: unused import: `ChannelSigner`
  --> lightning/src/events/bump_transaction.rs:29:19
   |
29 | use crate::sign::{ChannelSigner, EcdsaChannelSigner, SignerProvider, WriteableEcdsaChannelSigner};
   |                   ^^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (685f266) 90.33% compared to head (1babca4) 90.32%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2454      +/-   ##
==========================================
- Coverage   90.33%   90.32%   -0.02%     
==========================================
  Files         106      106              
  Lines       55732    55732              
  Branches    55732    55732              
==========================================
- Hits        50347    50338       -9     
- Misses       5385     5394       +9     
Files Changed Coverage Δ
lightning/src/events/bump_transaction.rs 77.55% <ø> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@optout21
Copy link
Contributor Author

One test failure, seems to be unrelated to the change.

@optout21 optout21 marked this pull request as ready for review July 26, 2023 22:01
Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@valentinewallace valentinewallace merged commit 390d49c into lightningdevkit:main Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants