Skip to content

Send error message to peer if we drop an unfunded channel on timeout #2496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

dunxen
Copy link
Contributor

@dunxen dunxen commented Aug 14, 2023

Fixes #2488.

Waiting on #2428.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 92.00% and no project coverage change.

Comparison is base (131560e) 90.35% compared to head (eda6e9d) 90.35%.
Report is 2 commits behind head on main.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2496   +/-   ##
=======================================
  Coverage   90.35%   90.35%           
=======================================
  Files         106      106           
  Lines       56242    56262   +20     
  Branches    56242    56262   +20     
=======================================
+ Hits        50816    50835   +19     
- Misses       5426     5427    +1     
Files Changed Coverage Δ
lightning/src/ln/functional_tests.rs 98.20% <85.71%> (-0.03%) ⬇️
lightning/src/ln/channelmanager.rs 85.70% <100.00%> (+0.02%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheBlueMatt TheBlueMatt merged commit a24626b into lightningdevkit:main Aug 14, 2023
@dunxen dunxen deleted the 2023-08-fix2488 branch August 15, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

process_unfunded_channel_tick in CHannelManager's timer tick not sending error message to peers if we drop a channel
4 participants