Downgrade log message "Channel Monitor sync is still in progress" from info to debug #2548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rogress from info to debug
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #2548 +/- ##
=======================================
Coverage 90.58% 90.58%
=======================================
Files 110 110
Lines 57526 57526
Branches 57526 57526
=======================================
Hits 52112 52112
Misses 5414 5414
☔ View full report in Codecov by Sentry. |
TheBlueMatt
approved these changes
Sep 3, 2023
tnull
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm persisting ChannelMonitors asynchronously to a distributed database and returning ChannelMonitorUpdateStatus::InProgress until the data is committed. The update only takes a few milliseconds and in that time I can see two occurrences of the message "A Channel Monitor sync is still in progress, refusing to provide monitor events!" in the logs. It's being triggered by the async background processor calling process_pending_events on the chain monitor and channel manager.
Everything appears to be working as expected so it seems to me this log message can be downgraded to debug given it is normal behavior. It is not necessary to print it twice every time there is a channel update.