Use Default::default() to construct () as a test scoring param
#2590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In bindings, we can't use unbounded generic types, and thus have to rip out the `ScoreParams` and replace them with static `ProbabilisticScoringFeeParams` universally. To make this easier, using `Default::default()` everywhere allows the type to change out from under the test without the test needing to change.
Codecov ReportPatch coverage:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2590 +/- ##
==========================================
- Coverage 88.83% 88.81% -0.03%
==========================================
Files 113 113
Lines 84534 84534
Branches 84534 84534
==========================================
- Hits 75097 75076 -21
- Misses 7210 7222 +12
- Partials 2227 2236 +9
☔ View full report in Codecov by Sentry. |
valentinewallace
approved these changes
Sep 21, 2023
jkczyz
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In bindings, we can't use unbounded generic types, and thus have to rip out the
ScoreParamsand replace them with staticProbabilisticScoringFeeParamsuniversally. To make this easier, usingDefault::default()everywhere allows the type to change out from under the test without the test needing to change.