Onion Error Handling #274
Merged
Onion Error Handling #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also be willing to forward something with a pubkey that we know is complete garbage, but upstream will just fail that with BADONION when they get it. I think this is kinda intended by the spec, but it definitely needs to be clarified.
ie dont generate them as they're a really obvious privacy leak. Luckily we were already handling them the same aside from log printing so don't have to touch anything there. I was lazy in updating tests but it only effects log printing, so whatever.
TheBlueMatt
force-pushed
the
2018-12-243-review
branch
from
c11009b to
caeff85
Compare
|
Better than it was, shouldn't completely break anything, is best effort anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase + fix of #243 (mostly things that were already mentioned there).