Skip to content

Onion Error Handling #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 18, 2018
Merged

Onion Error Handling #274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
096892c
Swap an if let for a match and add some TODO
yuntai Dec 17, 2018
7a8bec7
Rewrite most of process_onion_failure
yuntai Dec 17, 2018
4839ef7
Include flags when sending channel_disabled onion errors
yuntai Dec 17, 2018
7cfb09c
Add TODO noting confusion over |20 (channel_disabled) definition
TheBlueMatt Dec 17, 2018
b7e76c5
Always return malformed for BADONION errors
TheBlueMatt Dec 17, 2018
3870235
Add some additional channel-creation-broadcast-msg sanity checks
TheBlueMatt Dec 17, 2018
8783a74
Add test_util for overriding session privs for onion crypt
TheBlueMatt Dec 17, 2018
3f4ab94
Add tests for process_onion_failure return value sanity
yuntai Dec 17, 2018
caeff85
Update incorrect_payment_amount generation/handling for BOLT uptd
TheBlueMatt Dec 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions fuzz/fuzz_targets/full_stack_target.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ use lightning::chain::chaininterface::{BroadcasterInterface,ConfirmationTarget,C
use lightning::chain::transaction::OutPoint;
use lightning::chain::keysinterface::{ChannelKeys, KeysInterface};
use lightning::ln::channelmonitor;
use lightning::ln::channelmanager::{ChannelManager, PaymentFailReason, PaymentHash, PaymentPreimage};
use lightning::ln::channelmanager::{ChannelManager, PaymentHash, PaymentPreimage};
use lightning::ln::peer_handler::{MessageHandler,PeerManager,SocketDescriptor};
use lightning::ln::router::Router;
use lightning::util::events::{EventsProvider,Event};
Expand Down Expand Up @@ -419,7 +419,7 @@ pub fn do_test(data: &[u8], logger: &Arc<Logger>) {
// fulfill this HTLC, but if they are, we can just take the first byte and
// place that anywhere in our preimage.
if &payment.0[1..] != &[0; 31] {
channelmanager.fail_htlc_backwards(&payment, PaymentFailReason::PreimageUnknown);
channelmanager.fail_htlc_backwards(&payment, 0);
} else {
let mut payment_preimage = PaymentPreimage([0; 32]);
payment_preimage.0[0] = payment.0[0];
Expand All @@ -429,7 +429,7 @@ pub fn do_test(data: &[u8], logger: &Arc<Logger>) {
},
9 => {
for payment in payments_received.drain(..) {
channelmanager.fail_htlc_backwards(&payment, PaymentFailReason::PreimageUnknown);
channelmanager.fail_htlc_backwards(&payment, 0);
}
},
10 => {
Expand Down
Loading