Electrum: Use upstreamed validate_merkle_proof
#3180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3180 +/- ##
==========================================
- Coverage 89.82% 89.79% -0.04%
==========================================
Files 121 121
Lines 100404 100404
Branches 100404 100404
==========================================
- Hits 90190 90156 -34
- Misses 7550 7570 +20
- Partials 2664 2678 +14 ☔ View full report in Codecov by Sentry. |
We previously upstreamed the `validate_merkle_proof` utility method, which shipped with `electrum-client` 0.19.0. Since we upgraded to that version recently, we can now drop our local code and use the upstreamed version.
tnull
force-pushed
the
2024-07-use-upstreamed-merkle-validation
branch
from
7adc0c8 to
b3a58e6
Compare
TheBlueMatt
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously upstreamed the
validate_merkle_proofutility method, which shipped withelectrum-client0.19.0.Since we upgraded to that version recently, we can now drop our local code and use the upstreamed version.