Drop unnecessary strict feature from lightning-invoice
#3183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99aa6e2 detected that we had an undefined feature in `lightning-invoice` called `strict`, which was used to turn on `deny(warnings)`. It resolved that by adding the feature to the `Cargo.toml`, but we actually don't need it - our CI already builds with `-Dwarnings`, so any warnings should be rejected during CI and there's not a lot of value in having a (public) feature to do the same.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3183 +/- ##
==========================================
+ Coverage 89.76% 89.78% +0.01%
==========================================
Files 121 121
Lines 100402 100402
Branches 100402 100402
==========================================
+ Hits 90128 90148 +20
+ Misses 7591 7575 -16
+ Partials 2683 2679 -4 ☔ View full report in Codecov by Sentry. |
tnull
approved these changes
Jul 16, 2024
|
Turns out I can't land this as the |
|
Looks like CI had failed to start, which was considered a "failure" even though it didn't even try it...Kicked it and it passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
99aa6e2 detected that we had an undefined feature in
lightning-invoicecalledstrict, which was used to turn ondeny(warnings). It resolved that by adding the feature to theCargo.toml, but we actually don't need it - our CI already builds with-Dwarnings, so any warnings should be rejected during CI and there's not a lot of value in having a (public) feature to do the same.