Skip to content

Clarify maximum length of an invoice description #3185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tnull
Copy link
Contributor

@tnull tnull commented Jul 16, 2024

We previously stated in the docs that the invoice description can be at most 1023 bytes long, which is wrong. According to BOLT 11 it's at most 1023*5 bits (639 bytes) long.

We previously stated in the docs that the invoice description can be at most `1023`
bytes long, which is wrong. According to BOLT 11 it's at most 1023*5 bits (639 bytes) long.
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.73%. Comparing base (dd5d297) to head (fa7ecc5).
Report is 8 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3185      +/-   ##
==========================================
- Coverage   89.82%   89.73%   -0.10%     
==========================================
  Files         121      121              
  Lines      100404   100834     +430     
  Branches   100404   100834     +430     
==========================================
+ Hits        90190    90480     +290     
- Misses       7550     7691     +141     
+ Partials     2664     2663       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol, that's not a clarification, that's a correction. The old thing was very clearly wrong.

@TheBlueMatt
Copy link
Collaborator

Docs-only and the code trivially matches the new docs.

@TheBlueMatt TheBlueMatt merged commit dee3ba7 into lightningdevkit:main Jul 16, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants