Make minimum channel opening confirmations configurable #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgeisler
force-pushed
the
configurable_min_depth
branch
2 times, most recently
from
09db8bd to
aa8edd9
Compare
|
Thanks. Hmm, somewhere we should clarify that this field applies to *inbound* channels (whereas I'd generally assume "own channel" to refer to outbound channels). Maybe also make peer_channel_limits more explicit by calling it something like peer_channel_config_limits to clarify the relationship between our_channel_config and peer_..._limits?
… On Mar 26, 2019, at 15:27, Sebastian Geisler ***@***.***> wrote:
This also changes the default confirmations needed to open a channel from 12 to 6 since c-lightning will not accept values bigger than 10.
Ideally the user could provide a function Fn(channel_value_satoshis_msat: u64, value_to_self_msat: u64) -> u32, but providing a constant seems to be the more pragmatic solution for now.
You can view, comment on, or merge this pull request online at:
#330
Commit Summary
Make minimum channel opening confirmations configurable
File Changes
M src/ln/channel.rs (39)
M src/ln/functional_test_utils.rs (2)
M src/util/config.rs (23)
Patch Links:
https://github.com/rust-bitcoin/rust-lightning/pull/330.patch
https://github.com/rust-bitcoin/rust-lightning/pull/330.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
sgeisler
force-pushed
the
configurable_min_depth
branch
from
aa8edd9 to
56e779a
Compare
and change default from 12 to 6 (c-lightning compat)
sgeisler
force-pushed
the
configurable_min_depth
branch
from
56e779a to
dd21fe6
Compare
TheBlueMatt
reviewed
Mar 28, 2019
| /// Configuration we want to opening channels | ||
| #[derive(Clone, Debug)] | ||
| pub struct ChannelHandshakeConfig { | ||
| /// Confirmations we will wait for before considering the channel locked in |
There was a problem hiding this comment.
Can you mention its for inbound channels?
| /// Limits applied during channel creation. | ||
| pub channel_limits: ChannelHandshakeLimits, | ||
| pub peer_channel_config_limits: ChannelHandshakeLimits, |
There was a problem hiding this comment.
Can you change the comment above to say something like "Limits applied to the peer's channel config parameters during channel creation".
|
Will take as #335. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also changes the default confirmations needed to open a channel from 12 to 6 since c-lightning will not accept values bigger than 10.
Ideally the user could provide a function
Fn(channel_value_satoshis_msat: u64, value_to_self_msat: u64) -> u32, but providing a constant seems to be the more pragmatic solution for now.