Add additional test coverage of NetworkGraph counters
#3388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would have caught the bug fixed in 0c0cb6f in our tests. Suggested by @valentinewallace.
valentinewallace
approved these changes
Oct 29, 2024
tnull
reviewed
Oct 30, 2024
| @@ -2089,6 +2089,10 @@ where | |||
| }; | |||
| } | |||
|
|
|||
| core::mem::drop(nodes); | |||
There was a problem hiding this comment.
Mind adding a comment here that will explain our future-selves what this does?
There was a problem hiding this comment.
What's not clear here? If you remove this many tests instantly fail with recursive lock errors :)
There was a problem hiding this comment.
Well, it's pretty clear in the context of this PR, but in a month for now it might not be as obvious why we manually drop here, etc. Would be great to just add a brief comment.
There was a problem hiding this comment.
Why else would you mem::drop a lock? I'm not really a fan of adding comments if I don't see why someone would get confused...
There was a problem hiding this comment.
Alright, doesn't matter too much, going ahead and landing this
tnull
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would have caught the bug fixed in 0c0cb6f in our tests.
Suggested by @valentinewallace.