Add deserialize+load steps to chanmon_fail_consistency (fixes #327) #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies chanmon_fail_consistency greatly and makes it a tiny bit more realistic. It also sets us up for more disconnect-relatex events without the complexity blowing up.
TheBlueMatt
force-pushed
the
2019-07-more-chanmon-fuzz
branch
3 times, most recently
from
87e3856 to
27ac85b
Compare
TheBlueMatt
force-pushed
the
2019-07-more-chanmon-fuzz
branch
from
27ac85b to
20efabd
Compare
ariard
approved these changes
Jul 24, 2019
| @@ -363,13 +364,18 @@ pub fn do_test(data: &[u8]) { | |||
|
|
|||
| macro_rules! process_msg_events { | |||
| ($node: expr, $corrupt_forward: expr) => { { | |||
| for event in nodes[$node].get_and_clear_pending_msg_events() { | |||
| let events = if $node == 1 { | |||
There was a problem hiding this comment.
Hmmm so in fact we test only test A <--> B and B <--> C but never A <--> B, doing so would let us hit new cases ? Like maybe cyclic payment.
There was a problem hiding this comment.
Yea, seems like a reasonable next step to try to fuzz, but not 100% sure it'll add too much.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands the chanmon_fail_consistency test quite a bit by serializing/loading ChannelManagers/monitors, including potentially stale-but-UpdateTemporaryFailed monitors!